PyiiASMH

[hawkeye2777]

EDIT (for the >9000 time): <notes about branch instruction bug removed, not relevant anymore - see patch below>

Branch instruction bug is actually fixed now - made a really dumb error in my code... patch included below.

What to patch - vdappc.py (make sure to open it in a text editor, e.g. notepad):

Spoiler for Hiden:

1.) Find the following snippet (lines 52-62):

Code:

            #branch instruction fixes
            for i in range(len(b)):
                if ("0x" in b[i]) == True:
                    c.append(b[i])
            for i in range(len(c)):       
                c[i] = c[i][15:].split("\t", 1)[0]
            for i in range(len(a)):
                if ("0x" in a[i]) == True:
                    j = 0
                    a[i] = a[i].split("0x")[0]+"0x"+c[j]
                    j = j + 1

2.) Replace it with this:

Code:

            #branch instruction fixes
            for i in range(len(b)):
                if ("0x" in b[i]) == True:
                    c.append(b[i])
            for i in range(len(c)):       
                c[i] = c[i][15:].split("\t", 1)[0]
            for i in range(len(a)):
                if i == 0:
                    j = 0
                if ("0x" in a[i]) == True:
                    a[i] = a[i].split("0x")[0]+"0x"+c[j]
                    j = j + 1

Why did it not work before? Because j kept getting reassigned to 0...

---

Also, the single line

# 0

still causes 35% stop, but there's the following message in the command line console


Traceback (most recent call last):
  File "F:\Wii\wiird\pyiiasmh-0.9.3-win32\PyiiASMH.py", line 249, in assemble
    numlines = ("%x" % ((len(asm.codelist) / 2) + 1, )).upper()
AttributeError: Assemble instance has no attribute 'codelist'

That traceback will be helpful, but I still can't reproduce or find a potential fix... I have ideas now of what is causing the problem, but have no idea which is the true culprit.

*I apologize if parts of this post don't make any sense... had a long day to say the least. xD

[hawkeye2777]

Finally finished.

EDIT (Update - v2.0.0 released):

PyiiASMH is a cross-platform WiiRd ASM helper tool coded in Python. Go to Google Code to check it out and download it. Please submit feedback, bug reports, etc. if you have any.

Changelog:

Spoiler for Hiden:

PyiiASMH 2.0.0 (March 10, 2012):
    - Complete rewrite of the old code
    - New CLI interface (WIP)
    - New redesigned GUI (more internal changes)
    - PySide now supported
    - Multiple session support (opening/saving to files anywhere)
    - New preferences dialog with GUI Style selector, default codetype
      selector, confirmation prompts, and loading the last session on startup
    - Fields used for bapo, xor, and chksum now only allow hexadecimal input
    - Better error handling (most errors/exceptions logged to error.log)
    - Relicensed under the "new" BSD license
    - Cleaner code (WIP)
    - Bug fixes

What you need (summary):
 - Python 2.6.x or 2.7.x (download)
 - PySide 1.0.6+ (download) OR PyQt 4.7.x+ (download)

Other notes:
 - PyiiASMH is now released under the "new"/"modified"/clause 3 BSD license.
 - For those of you who like to redistribute/repackage stuff, you cannot pack PyQt with PyiiASMH; the GPL doesn't allow it (unless PyiiASMH were GPL'd, which it is not anymore). However, I'll be working on "native" packages soon for Windows (and hopefully OS X too) using PySide instead, so just be patient... or just install stuff manually; it won't kill you.
 
Think that's all; ask away if you need to.

As always, let me know if you find a bug or a screwup (pretty likely; given the time that I posted this).

[Bully@Wiiplaza]

cool I was looking forward to thoses fixes.

Btw. do Windows 7 64bit folks need to install the following:

http://www.riverbankcomputing.co.uk/static/Downloads/PyQt4/PyQt-Py3.2-x64-gpl-4.9.1-1.exe
http://www.python.org/ftp/python/2.7.2/python-2.7.2.msi

And then extract this to a folder:
http://code.google.com/p/pyiiasmh/downloads/detail?name=pyiiasmh-2.0.0-win32.zip

Cuz I just copied in the new files and it failed to boot the application...

[hawkeye2777]

For windows, I don't think it matters if you install 32 or 64 bits... as long as both python and pyqt/pyside are both 32 bits or both 64 bits. For the app archive, extract it anywhere where you have permissions to be safe.

For your problem, you installed PyQt for Python 3.2 instead of 2.7 (grab the PyQt installer with Py2.7).

[Bully@Wiiplaza]

 

Downloads for Win7 64bit:
http://www.riverbankcomputing.co.uk/static/Downloads/PyQt4/PyQt-Py2.7-x64-gpl-4.9.1-1.exe
http://python.org/ftp/python/2.7.2/python-2.7.2.amd64.msi
http://pyiiasmh.googlecode.com/files/pyiiasmh-2.0.0-win32.zip

1.) Run the installer from the first two links
2.) Extract the contents of the third link anywhere and run the application

DONE.

[hawkeye2777]

A couple of compatibility issues with older versions of PySide/PyQt have surfaced; at least one issue is fixed, let me know if others come up. The fixes are on the git repo right now (I'll make a new release eventually).

[fantleas]

Just a few bugs/suggestions:

1.

I have an "en dash" character (\u2013) inside one comment of my code. PyiiASMh won't assemble the code if this character is found. Old PyiiASMh didn't have this problem.

This is the output I get from the console:

"Traceback (most recent call last):
  File ".\pyiiasmh.py", line 420, in <lambda>
    lambda: self.convert("asm"))
  File ".\pyiiasmh.py", line 63, in convert
    self.get_uivars(action)
  File ".\pyiiasmh.py", line 98, in get_uivars
    self.opcodes = str(self.ui.opcodesPTextEdit.toPlainText())+"\n"
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2013' in position 1
6587: ordinal not in range(128)"

--------

2.

Also, when using only Python 2.7.2 and PyQt 4.9.1 (both x64), the application works fine. However, looking forward to the future "native packages" you mentioned, I decided to install PySide 1.1.0 for Python 2.7 (amd64).
Surprisingly, PyiiASMH is unable to launch with PySide installed. The console opens and prints some output, then instantly closes. I checked the error logs but couldn't find anything related to the crashes.

--------

3.

Suggestion: When expanding the window, the options panel (Address/Offset, XOR Checksum, Code Type, etc.) should not be expanded at all. Instead, the panel should keep its default size, allowing the text boxes to have a bigger vertical size.



Edit: Fixed typo. Had typed '\u2012' instead of '\u2013' for the Unicode character.

[Bully@Wiiplaza]

Also, PyiiASMH is WAY slower than ASMWiiRd in terms of convertion to Gecko Code.
I once rendered a video (eats up almost all CPU power), hit the convert button. Waiting... nothing happened for like 10 seconds.
I booted ASMWiiRd, pasted the same assembly, hit the convert button. About 3 secs later, ASMWiiRd gave out the converted code while PyiiASMH still wasn´t done with the "same job".

[hetoan2]

PyiiASMH has never taken more than a second for me... Are you sure your python install is correct?

I know it can "freeze" on certain %s if you're missing things... Check your filestructure too, because a missing folder may be the culprit.

[Bully@Wiiplaza]

PyiiASMH has never taken more than a second for me... Are you sure your python install is correct?

I know it can "freeze" on certain %s if you're missing things... Check your filestructure too, because a missing folder may be the culprit.

It *only* applies when I don´t render a video at the same time.
Yes, it normally works fine, just like you described. I noticed that on low remaining CPU power ASMWiiRd converts way faster.
Wonder what´s the reason for it, they both do the same operation.

[hetoan2]

PyiiASMh is not already compiled. Every time you run the .py file it creates a .pyo/.pyc file (i'm fairly certain it doesn't reuse, although i'm not entirely sure) and the exe is already compiled.

Also PyiiASMh has more features. You can't do things like macros or certain pseudoops like you can with PyiiASMh. :\

[dcx2]

I've seen ASMWiiRd convert pretty much anything.  Only problem is you need to make sure you maximize the window so there is no word wrap going on in the ASM window; it really chokes on that.

PyiiASMH lets me compile raw, though, which I've used for compiling multiple C2 codes simultaneously.  I had to do all of them in one pass so that they could automatically calculate pointers to data from other C2 codes.

FWIW, I can't remember there being a significant difference in speed between one or the other.

[hawkeye2777]

If you monitored which threads or cores each program runs on, that could be why PyiiASMH may be slower under heavy CPU load. So, unless some of the modules used use multiple threads, PyiiASMH is probably locked to one thread, and if that thread is on the CPU with a heavy load that will probably slow it down. I have no idea how to monitor that on Windows or how Windows handles that kind of stuff, so I can't help there; concurrency stuff is on my TODO list though once I get a chance to put it in. Other than that, I'm guessing it isn't a problem with the PyiiASMH program itself. Like ASMWiiRd, it is just a frontend for the powerpc-eabi-as, vdappc, etc. tools; all it does is "automate" the process of using those tools for you.

Just a few bugs/suggestions:

[...snip...]

--------

2.

Also, when using only Python 2.7.2 and PyQt 4.9.1 (both x64), the application works fine. However, looking forward to the future "native packages" you mentioned, I decided to install PySide 1.1.0 for Python 2.7 (amd64).
Surprisingly, PyiiASMH is unable to launch with PySide installed. The console opens and prints some output, then instantly closes. I checked the error logs but couldn't find anything related to the crashes.

--------

3.

Suggestion: When expanding the window, the options panel (Address/Offset, XOR Checksum, Code Type, etc.) should not be expanded at all. Instead, the panel should keep its default size, allowing the text boxes to have a bigger vertical size.

First of all, thanks for the feedback. Right now things are very busy for me as school is coming to a close, but hopefully I'll be able to tackle some of that stuff soon. For 2: I haven't had a chance to test PySide on Windows yet, so not sure why it's doing that (PySide works fine for me, under Linux). Somehow I wonder if it's a problem with environment variables on Windows... not sure, but it's something I'll have to look into. As far as #3 goes... well I'm not sure if I can do that, and if I can I don't know how to do that in Qt. I'll definitely consider that though.

[Bully@Wiiplaza]

A little bug I´ve found:

If you put a lot of assembly instructions into the compiler, it will miss out zeros in the first line before the lines counter value. The more instructions, the more zeros are left out

Try to compile this:

Spoiler for Hiden:

lwz r5,0(r4)

lis r10, 0x8053
lhz r10, 0x56D2 (r10)

lis r12, 0x9371

cmpwi r10, 0x1000
bne- _END

stw r5, 0 (r12)
lwz r11, 4 (r4)
stw r11, 4 (r12)
lwz r11, 8 (r4)
stw r11, 8 (r12)
lwz r11, 12 (r4)
stw r11, 12 (r12)
lwz r11, 16 (r4)
stw r11, 16 (r12)
lwz r11, 20 (r4)
stw r11, 20 (r12)
lwz r11, 24 (r4)
stw r11, 24 (r12)
lwz r11, 28 (r4)
stw r11, 28 (r12)
lwz r11, 32 (r4)
stw r11, 32 (r12)
lwz r11, 36 (r4)
stw r11, 36 (r12)
lwz r11, 40 (r4)
stw r11, 40 (r12)
lwz r11, 44 (r4)
stw r11, 44 (r12)
lwz r11, 48 (r4)
stw r11, 48 (r12)
lwz r11, 52 (r4)
stw r11, 52 (r12)
lwz r11, 56 (r4)
stw r11, 56 (r12)
lwz r11, 60 (r4)
stw r11, 60 (r12)
lwz r11, 64 (r4)
stw r11, 64 (r12)
lwz r11, 68 (r4)
stw r11, 68 (r12)
lwz r11, 72 (r4)
stw r11, 72 (r12)
lwz r11, 76 (r4)
stw r11, 76 (r12)
lwz r11, 80 (r4)
stw r11, 80 (r12)
lwz r11, 84 (r4)
stw r11, 84 (r12)
lwz r11, 88 (r4)
stw r11, 88 (r12)
lwz r11, 92 (r4)
stw r11, 92 (r12)
lwz r11, 96 (r4)
stw r11, 96 (r12)
lwz r11, 100 (r4)
stw r11, 100 (r12)
lwz r11, 104 (r4)
stw r11, 104 (r12)
lwz r11, 108 (r4)
stw r11, 108 (r12)
lwz r11, 112 (r4)
stw r11, 112 (r12)
lwz r11, 116 (r4)
stw r11, 116 (r12)
lwz r11, 120 (r4)
stw r11, 120 (r12)
lwz r11, 124 (r4)
stw r11, 124 (r12)
lwz r11, 126 (r4)
stw r11, 126 (r12)
lwz r11, 130 (r4)
stw r11, 130 (r12)
lwz r11, 134 (r4)
stw r11, 134 (r12)
lwz r11, 138 (r4)
stw r11, 138 (r12)
lwz r11, 142 (r4)
stw r11, 142 (r12)
lwz r11, 146 (r4)
stw r11, 146 (r12)
lwz r11, 150 (r4)
stw r11, 150 (r12)
lwz r11, 154 (r4)
stw r11, 154 (r12)
lwz r11, 158 (r4)
stw r11, 158 (r12)
lwz r11, 162 (r4)
stw r11, 162 (r12)
lwz r11, 166 (r4)
stw r11, 166 (r12)
lwz r11, 170 (r4)
stw r11, 170 (r12)
lwz r11, 174 (r4)
stw r11, 174 (r12)
lwz r11, 178 (r4)
stw r11, 178 (r12)
lwz r11, 182 (r4)
stw r11, 182 (r12)
lwz r11, 186 (r4)
stw r11, 186 (r12)
lwz r11, 190 (r4)
stw r11, 190 (r12)
lwz r11, 194 (r4)
stw r11, 194 (r12)
lwz r11, 198 (r4)
stw r11, 198 (r12)
lwz r11, 202 (r4)
stw r11, 202 (r12)
lwz r11, 208 (r4)
stw r11, 208 (r12)
lwz r11, 212 (r4)
stw r11, 212 (r12)
lwz r11, 216 (r4)
stw r11, 216 (r12)

_END:

cmpwi r10, 0x10
bne- _ENDO

lwz r11, 0 (r12)
stw r11, 0 (r4)
lwz r11, 4 (r12)
stw r11, 4 (r4)
lwz r11, 8 (r12)
stw r11, 8 (r4)
lwz r11, 12 (r12)
stw r11, 12 (r4)
lwz r11, 16 (r12)
stw r11, 16 (r4)
lwz r11, 20 (r12)
stw r11, 20 (r4)
lwz r11, 24 (r12)
stw r11, 24 (r4)
lwz r11, 28 (r12)
stw r11, 28 (r4)
lwz r11, 32 (r12)
stw r11, 32 (r4)
lwz r11, 36 (r12)
stw r11, 36 (r4)
lwz r11, 40 (r12)
stw r11, 40 (r4)
lwz r11, 44 (r12)
stw r11, 44 (r4)
lwz r11, 48 (r12)
stw r11, 48 (r4)
lwz r11, 52 (r12)
stw r11, 52 (r4)
lwz r11, 56 (r12)
stw r11, 56 (r4)
lwz r11, 60 (r12)
stw r11, 60 (r4)
lwz r11, 64 (r12)
stw r11, 64 (r4)
lwz r11, 68 (r12)
stw r11, 68 (r4)
lwz r11, 72 (r12)
stw r11, 72 (r4)
lwz r11, 76 (r12)
stw r11, 76 (r4)
lwz r11, 80 (r12)
stw r11, 80 (r4)
lwz r11, 84 (r12)
stw r11, 84 (r4)
lwz r11, 88 (r12)
stw r11, 88 (r4)
lwz r11, 92 (r12)
stw r11, 92 (r4)
lwz r11, 96 (r12)
stw r11, 96 (r4)
lwz r11, 100 (r12)
stw r11, 100 (r4)
lwz r11, 104 (r12)
stw r11, 104 (r4)
lwz r11, 108 (r12)
stw r11, 108 (r4)
lwz r11, 112 (r12)
stw r11, 112 (r4)
lwz r11, 116 (r12)
stw r11, 116 (r4)
lwz r11, 120 (r12)
stw r11, 120 (r4)
lwz r11, 124 (r12)
stw r11, 124 (r4)
lwz r11, 126 (r12)
stw r11, 126 (r4)
lwz r11, 130 (r12)
stw r11, 130 (r4)
lwz r11, 134 (r12)
stw r11, 134 (r4)
lwz r11, 138 (r12)
stw r11, 138 (r4)
lwz r11, 142 (r12)
stw r11, 142 (r4)
lwz r11, 146 (r12)
stw r11, 146 (r4)
lwz r11, 150 (r12)
stw r11, 150 (r4)
lwz r11, 154 (r12)
stw r11, 154 (r4)
lwz r11, 158 (r12)
stw r11, 158 (r4)
lwz r11, 162 (r12)
stw r11, 162 (r4)
lwz r11, 166 (r12)
stw r11, 166 (r4)
lwz r11, 170 (r12)
stw r11, 170 (r4)
lwz r11, 174 (r12)
stw r11, 174 (r4)
lwz r11, 178 (r12)
stw r11, 178 (r4)
lwz r11, 182 (r12)
stw r11, 182 (r4)
lwz r11, 186 (r12)
stw r11, 186 (r4)
lwz r11, 190 (r12)
stw r11, 190 (r4)
lwz r11, 194 (r12)
stw r11, 194 (r4)
lwz r11, 198 (r12)
stw r11, 198 (r4)
lwz r11, 202 (r12)
stw r11, 202 (r4)
lwz r11, 208 (r12)
stw r11, 208 (r4)
lwz r11, 212 (r12)
stw r11, 212 (r4)
lwz r11, 216 (r12)
stw r11, 216 (r4)

_ENDO:

Zeros are missing...

Spoiler for Hiden:

C2000000 72
80A40000 3D408053
A14A56D2 3D809371
2C0A1000 408201B8
90AC0000 81640004
916C0004 81640008
916C0008 8164000C
916C000C 81640010
916C0010 81640014
916C0014 81640018
916C0018 8164001C
916C001C 81640020
916C0020 81640024
916C0024 81640028
916C0028 8164002C
916C002C 81640030
916C0030 81640034
916C0034 81640038
916C0038 8164003C
916C003C 81640040
916C0040 81640044
916C0044 81640048
916C0048 8164004C
916C004C 81640050
916C0050 81640054
916C0054 81640058
916C0058 8164005C
916C005C 81640060
916C0060 81640064
916C0064 81640068
916C0068 8164006C
916C006C 81640070
916C0070 81640074
916C0074 81640078
916C0078 8164007C
916C007C 8164007E
916C007E 81640082
916C0082 81640086
916C0086 8164008A
916C008A 8164008E
916C008E 81640092
916C0092 81640096
916C0096 8164009A
916C009A 8164009E
916C009E 816400A2
916C00A2 816400A6
916C00A6 816400AA
916C00AA 816400AE
916C00AE 816400B2
916C00B2 816400B6
916C00B6 816400BA
916C00BA 816400BE
916C00BE 816400C2
916C00C2 816400C6
916C00C6 816400CA
916C00CA 816400D0
916C00D0 816400D4
916C00D4 816400D8
916C00D8 2C0A0010
408201BC 816C0000
91640000 816C0004
91640004 816C0008
91640008 816C000C
9164000C 816C0010
91640010 816C0014
91640014 816C0018
91640018 816C001C
9164001C 816C0020
91640020 816C0024
91640024 816C0028
91640028 816C002C
9164002C 816C0030
91640030 816C0034
91640034 816C0038
91640038 816C003C
9164003C 816C0040
91640040 816C0044
91640044 816C0048
91640048 816C004C
9164004C 816C0050
91640050 816C0054
91640054 816C0058
91640058 816C005C
9164005C 816C0060
91640060 816C0064
91640064 816C0068
91640068 816C006C
9164006C 816C0070
91640070 816C0074
91640074 816C0078
91640078 816C007C
9164007C 816C007E
9164007E 816C0082
91640082 816C0086
91640086 816C008A
9164008A 816C008E
9164008E 816C0092
91640092 816C0096
91640096 816C009A
9164009A 816C009E
9164009E 816C00A2
916400A2 816C00A6
916400A6 816C00AA
916400AA 816C00AE
916400AE 816C00B2
916400B2 816C00B6
916400B6 816C00BA
916400BA 816C00BE
916400BE 816C00C2
916400C2 816C00C6
916400C6 816C00CA
916400CA 816C00D0
916400D0 816C00D4
916400D4 816C00D8
916400D8 00000000

No big deal, though. We can add them in.

Spoiler for Hiden:

C2000000 00000072
80A40000 3D408053
A14A56D2 3D809371
2C0A1000 408201B8
90AC0000 81640004
916C0004 81640008
916C0008 8164000C
916C000C 81640010
916C0010 81640014
916C0014 81640018
916C0018 8164001C
916C001C 81640020
916C0020 81640024
916C0024 81640028
916C0028 8164002C
916C002C 81640030
916C0030 81640034
916C0034 81640038
916C0038 8164003C
916C003C 81640040
916C0040 81640044
916C0044 81640048
916C0048 8164004C
916C004C 81640050
916C0050 81640054
916C0054 81640058
916C0058 8164005C
916C005C 81640060
916C0060 81640064
916C0064 81640068
916C0068 8164006C
916C006C 81640070
916C0070 81640074
916C0074 81640078
916C0078 8164007C
916C007C 8164007E
916C007E 81640082
916C0082 81640086
916C0086 8164008A
916C008A 8164008E
916C008E 81640092
916C0092 81640096
916C0096 8164009A
916C009A 8164009E
916C009E 816400A2
916C00A2 816400A6
916C00A6 816400AA
916C00AA 816400AE
916C00AE 816400B2
916C00B2 816400B6
916C00B6 816400BA
916C00BA 816400BE
916C00BE 816400C2
916C00C2 816400C6
916C00C6 816400CA
916C00CA 816400D0
916C00D0 816400D4
916C00D4 816400D8
916C00D8 2C0A0010
408201BC 816C0000
91640000 816C0004
91640004 816C0008
91640008 816C000C
9164000C 816C0010
91640010 816C0014
91640014 816C0018
91640018 816C001C
9164001C 816C0020
91640020 816C0024
91640024 816C0028
91640028 816C002C
9164002C 816C0030
91640030 816C0034
91640034 816C0038
91640038 816C003C
9164003C 816C0040
91640040 816C0044
91640044 816C0048
91640048 816C004C
9164004C 816C0050
91640050 816C0054
91640054 816C0058
91640058 816C005C
9164005C 816C0060
91640060 816C0064
91640064 816C0068
91640068 816C006C
9164006C 816C0070
91640070 816C0074
91640074 816C0078
91640078 816C007C
9164007C 816C007E
9164007E 816C0082
91640082 816C0086
91640086 816C008A
9164008A 816C008E
9164008E 816C0092
91640092 816C0096
91640096 816C009A
9164009A 816C009E
9164009E 816C00A2
916400A2 816C00A6
916400A6 816C00AA
916400AA 816C00AE
916400AE 816C00B2
916400B2 816C00B6
916400B6 816C00BA
916400BA 816C00BE
916400BE 816C00C2
916400C2 816C00C6
916400C6 816C00CA
916400CA 816C00D0
916400D0 816C00D4
916400D4 816C00D8
916400D8 00000000

[hawkeye2777]

Hey guys, I moved the repo to GitHub; everything that was at the Google Code page is there now. I'll probably leave the Google Code page up for a bit, but eventually I'll remove it (or at least post a link to the GitHub page).

A little bug I´ve found:

If you put a lot of assembly instructions into the compiler, it will miss out zeros in the first line before the lines counter value. The more instructions, the more zeros are left out

---SNIP---

Confirmed, thanks! I know where the problematic code is, so now I just have to think of how to fix it.

EDIT: If you want to fix this, here's a patch:

Code:

--- a/ppctools.py
+++ b/ppctools.py
@@ -208,7 +208,7 @@ def construct_code(rawhex, bapo=None, xor=None, chksum=None, ctype=None):
 
     numlines = ("%x" % len(rawhex.split("\n"))).upper()
     leading_zeros = []
-    for i in range(8 - (int(numlines, 16) // 16 + 1)):
+    for i in range(8 - len(str(numlines))):
         leading_zeros.append("0")
 
     if rawhex[-1] == " ":

Will be on GitHub soon.